-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add stac-geoparquet reading and writing #1521
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1521 +/- ##
==========================================
- Coverage 91.47% 91.44% -0.04%
==========================================
Files 54 54
Lines 7542 7560 +18
Branches 915 917 +2
==========================================
+ Hits 6899 6913 +14
- Misses 457 459 +2
- Partials 186 188 +2 ☔ View full report in Codecov by Sentry. |
Marking as draft while I dig into some PyPI size restrictions that are keeping me from releasing Windoze wheels that work. |
cls: type[C], | ||
href: HREF, | ||
stac_io: pystac.StacIO | None = None, | ||
is_geoparquet: bool | None = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At first read I don't love the idea of adding another "how to read" flag. I feel like that is really what stac_io
is meant for - this kind of messes up the existing patterns. Like how would you go about defining a different way to read from geoparquet?
On the other hand I guess adding stacrs
here will make reading from geoparquet work in the pystac-client case as well even thought that one uses a different stac_io
. So maybe this is a practical solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I don't love it either — it's the complexity of "STAC but in different formats" bleeding into our software implementation. I'll have a think.
Related Issue(s):
Description:
PR Checklist:
pre-commit run --all-files
)pytest
)