Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(stackable-versioned): Update usage guide #864

Merged
merged 8 commits into from
Sep 12, 2024

Conversation

Techassi
Copy link
Member

@Techassi Techassi commented Sep 11, 2024

Part of stackabletech/issues#507

Tip

Can be rendered locally using:

cargo doc -p stackable-versioned --document-private-items --all-features

This updates the usage guide as well as mention that the macro must be placed before all other macros and attributes.

Reviewer

@Techassi Techassi marked this pull request as ready for review September 12, 2024 11:02
@NickLarsenNZ NickLarsenNZ self-requested a review September 12, 2024 12:59
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review.

crates/stackable-versioned-macros/src/attrs/common/item.rs Outdated Show resolved Hide resolved
crates/stackable-versioned-macros/src/lib.rs Show resolved Hide resolved
crates/stackable-versioned-macros/src/lib.rs Outdated Show resolved Hide resolved
crates/stackable-versioned-macros/src/lib.rs Outdated Show resolved Hide resolved
crates/stackable-versioned-macros/src/lib.rs Outdated Show resolved Hide resolved
crates/stackable-versioned-macros/src/lib.rs Outdated Show resolved Hide resolved
crates/stackable-versioned-macros/src/lib.rs Outdated Show resolved Hide resolved
crates/stackable-versioned-macros/src/lib.rs Outdated Show resolved Hide resolved
crates/stackable-versioned-macros/src/lib.rs Outdated Show resolved Hide resolved
crates/stackable-versioned-macros/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Techassi Techassi added this pull request to the merge queue Sep 12, 2024
Merged via the queue into main with commit 4c67dbd Sep 12, 2024
10 checks passed
@Techassi Techassi deleted the docs/crd-versioning-macro-order branch September 12, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants