Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Authorization overhaul #186

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - Authorization overhaul #186

wants to merge 8 commits into from

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Apr 8, 2022 •
edited by fhennig
Loading

Description

  • removed authorization module
  • switched to OpaConfig from operator-rs

closes #167

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@maltesander maltesander requested a review from a team April 8, 2022 10:19
@fhennig
Copy link
Contributor

fhennig commented Apr 12, 2022

I'll review this

Felix Hennig added 2 commits April 12, 2022 14:10
@fhennig
Copy link
Contributor

fhennig commented Apr 12, 2022

Alright, so the code looks good, I'll test now

@fhennig
Copy link
Contributor

fhennig commented Apr 12, 2022

The dependency on the secret operator is not documented

@fhennig
Copy link
Contributor

fhennig commented Apr 12, 2022

The documentation doesn't say how to get to the Web UI

fhennig
fhennig approved these changes Apr 13, 2022
View reviewed changes
Copy link
Contributor

@fhennig fhennig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created tickets for the documentation issues as well as the missing test

@maltesander
Copy link
Member Author

I've created tickets for the documentation issues as well as the missing test

Thanks!

@maltesander
Copy link
Member Author

bors merge

bors bot pushed a commit that referenced this pull request Apr 13, 2022
@maltesander
Authorization overhaul (#186)
ee23658 
## Description

- removed authorization module
- switched to `OpaConfig` from operator-rs

closes #167



Co-authored-by: Malte Sander <[email protected]>
Co-authored-by: Felix Hennig <[email protected]>
@bors
Copy link
Contributor

bors bot commented Apr 13, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Authorization overhaul [Merged by Bors] - Authorization overhaul Apr 13, 2022
@bors bors bot closed this Apr 13, 2022
@bors bors bot deleted the authorization_overhaul branch April 13, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhennig fhennig fhennig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Complete Overhaul of authorization CRD parts
2 participants
@maltesander @fhennig