[Merged by Bors] - Adapt S3 configuration to ADR016 #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…work_s3_configuration # Conflicts: # rust/operator-binary/src/controller.rs
siegfriedweber
force-pushed
the
rework_s3_configuration
branch
6 times, most recently
from
5acf1da to
cbb1168
Compare
siegfriedweber
force-pushed
the
rework_s3_configuration
branch
from
cbb1168 to
7bdf217
Compare
|
This pull request is ready for review but it may only be merged after operator-rs is upgraded to 0.20.0 and the according patch is removed from the workspace Cargo.toml. |
maltesander
reviewed
May 11, 2022
sbernauer
reviewed
May 11, 2022
…work_s3_configuration # Conflicts: # CHANGELOG.md # Cargo.lock # deploy/crd/trinocluster.crd.yaml # deploy/helm/trino-operator/crds/crds.yaml # deploy/manifests/crds.yaml # docs/modules/ROOT/pages/usage.adoc # rust/crd/src/lib.rs # rust/operator-binary/src/controller.rs
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
May 18, 2022
## Description Configuration of S3 adapted to ADR016 Closes #166 Integrationtest: https://github.com/stackabletech/integration-tests/pull/237 Currently requires a certain secret operator pr: `helm install secret-operator stackable-test/secret-operator --version=0.3.0-pr125` ### TODO - [x] Use operator-rs tag 0.21.0 Co-authored-by: Malte Sander <[email protected]>
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Configuration of S3 adapted to ADR016
Closes #166
Integrationtest: https://github.com/stackabletech/integration-tests/pull/237
Currently requires a certain secret operator pr:
helm install secret-operator stackable-test/secret-operator --version=0.3.0-pr125TODO
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information