Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Support specifying Service type #406

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - Support specifying Service type #406

wants to merge 7 commits into from

Conversation

sbernauer
Copy link
Member

Description

For stackabletech/issues#360

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Preview Give feedback

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@sbernauer sbernauer mentioned this pull request Apr 4, 2023
Closed
@sbernauer sbernauer force-pushed the feat/service-type branch from 2a8b2df to 15998f7 Compare April 4, 2023 07:32
@sbernauer sbernauer force-pushed the feat/service-type branch from 15998f7 to 003ad61 Compare April 4, 2023 08:25
@sbernauer sbernauer self-assigned this Apr 4, 2023
@sbernauer sbernauer requested a review from a team April 4, 2023 08:39
maltesander
maltesander approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if we agreed on the listener_class names :)

CHANGELOG.md Outdated Show resolved Hide resolved
@sbernauer
Copy link
Member Author

We chatted about this in #product-listener and decided to stick with the current names

@sbernauer
Copy link
Member Author

Started test https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/trino-operator-it-custom/64/

@sbernauer
Copy link
Member Author

Test failed, but I think it's normal flakiness

@sbernauer
Copy link
Member Author

Started https://ci.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/trino-operator-it-custom/65/

@sbernauer
Copy link
Member Author

bors r+
Test passed

bors bot pushed a commit that referenced this pull request Apr 6, 2023
@sbernauer
Support specifying Service type (#406)
0f47c07 
# Description

For stackabletech/issues#360

*Please add a description here. This will become the commit message of the merge request later.*
@bors
Copy link
Contributor

bors bot commented Apr 6, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Support specifying Service type [Merged by Bors] - Support specifying Service type Apr 6, 2023
@bors bors bot closed this Apr 6, 2023
@bors bors bot deleted the feat/service-type branch April 6, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maltesander maltesander maltesander approved these changes

Assignees

@sbernauer sbernauer

Labels
release/23.4.0
Projects
Stackable Engineering
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbernauer @maltesander