Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to use ansible-collection-openstack #20

Merged
merged 7 commits into from
Mar 4, 2024
Merged

Convert to use ansible-collection-openstack #20

merged 7 commits into from
Mar 4, 2024

Conversation

scrungus
Copy link
Contributor

@scrungus scrungus commented Nov 30, 2023 •
edited by markgoddard
Loading

No description provided.

@scrungus scrungus marked this pull request as ready for review December 4, 2023 17:07
@scrungus scrungus requested a review from a team as a code owner December 4, 2023 17:07
@scrungus scrungus requested a review from markgoddard December 4, 2023 17:07
@scrungus scrungus changed the title WIP: Convert to use ansible-collection-openstack Convert to use ansible-collection-openstack Dec 6, 2023
markgoddard
markgoddard reviewed Dec 6, 2023
View reviewed changes
Copy link

@markgoddard markgoddard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks good. Possibly needs more testing of the collection.

README.rst Show resolved Hide resolved
@markgoddard
Copy link

I tested this (with care) against a production OpenStack deployment. A few things I noticed:

  • There is a bug in the openstack.cloud.router module that prevents it from using an external network by name in a different project. This is probably a blocker, since it's quite a common scenario.
  • The Injected file content bytes quota was previously ignored, but now seems to be applied.

@markgoddard markgoddard mentioned this pull request Jan 26, 2024
Closed
@scrungus
Copy link
Contributor Author

scrungus commented Feb 8, 2024

@markgoddard there's a fix proposed now https://review.opendev.org/c/openstack/ansible-collections-openstack/+/905979, maybe someone on our side can add to the discussion?

@sd109
Copy link
Member

sd109 commented Feb 26, 2024

Proposed workaround for blocking router module bug stackhpc/ansible-collection-openstack#27

@markgoddard
Copy link

@markgoddard there's a fix proposed now https://review.opendev.org/c/openstack/ansible-collections-openstack/+/905979, maybe someone on our side can add to the discussion?

I know, I proposed it 😆

@markgoddard markgoddard merged commit fbe04a0 into main Mar 4, 2024
@markgoddard markgoddard deleted the convert-ans-coll branch March 4, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markgoddard markgoddard markgoddard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scrungus @markgoddard @sd109