benches: improve resolution of add_prices
#603
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The range of values the `add_prices` benchmark is performed under doesn't showcase the important of the behavior that we want to capture very well - meaning the transition from the "interpreter better" to "webassembly better" regimes. This commit improves that by changing this range to a more representative value.
|
Also, it seems like the contract this bench is inspired on was consistently called with 14 price updates. This number is interesting since it is effectively the number at which the webassembly runtime starts exhibiting better behavior than the interpreter - meaning the contract would have benefited, albeit very slightly, from the runtime. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #603 +/- ##
=======================================
Coverage 85.65% 85.65%
=======================================
Files 46 46
Lines 24554 24554
Branches 24554 24554
=======================================
Hits 21032 21032
Misses 1672 1672
Partials 1850 1850 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The range of values the
add_pricesbenchmark is performed under doesn't showcase the important of the behavior that we want to capture very well - meaning the transition from the "interpreter better" to "webassembly better" regimes. This commit improves that by changing this range to a more representative value.