Nakamoto: Validate stacker signature of a Nakamoto Block

[jferrant]

Description

Add functionality to check if a Nakamoto block has been correctly signed with the Signers (Stackers) WSTS signature associated with the aggregate public key.

Applicable issues

• fixes Nakamoto: Implement the stacker signature / set validation in the Sortition DB #3927

[codecov]

Codecov Report

Attention: 421 lines in your changes are missing coverage. Please review.

Comparison is base (1bb5331) 0.04% compared to head (6eeff19) 0.04%.
Report is 3 commits behind head on next.

Files	Patch %	Lines
stacks-common/src/util/secp256k1.rs	0.00%	86 Missing ⚠️
stackslib/src/chainstate/nakamoto/mod.rs	0.00%	74 Missing ⚠️
stackslib/src/chainstate/nakamoto/tests/node.rs	0.00%	72 Missing ⚠️
...kslib/src/chainstate/nakamoto/coordinator/tests.rs	0.00%	57 Missing ⚠️
stackslib/src/chainstate/stacks/boot/mod.rs	0.00%	39 Missing ⚠️
stackslib/src/net/relay.rs	0.00%	30 Missing ⚠️
testnet/stacks-node/src/mockamoto.rs	0.00%	25 Missing ⚠️
stackslib/src/chainstate/stacks/transaction.rs	0.00%	12 Missing ⚠️
stacks-signer/src/runloop.rs	0.00%	11 Missing ⚠️
stackslib/src/chainstate/burn/db/sortdb.rs	0.00%	7 Missing ⚠️
... and 5 more

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #4039      +/-   ##
==========================================
- Coverage    0.04%    0.04%   -0.01%     
==========================================
  Files         419      419              
  Lines      297652   297992     +340     
==========================================
  Hits          136      136              
- Misses     297516   297856     +340     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[obycode]

LGTM! I just had one minor suggestion.
May the Schwartz be with you.

[kantai]

LGTM -- only had a minor comment

[jcnelson]

I don't think we should be using MessageSignature to encapsulate a Schnorr signature. I was using that as a placeholder for a Schnorr-specific signature type.

If you can instead create a Schnorr signature container, and use that in place of MessageSignature in the block header, then I'll approve 👍

[jferrant]

I don't think we should be using MessageSignature to encapsulate a Schnorr signature. I was using that as a placeholder for a Schnorr-specific signature type.

If you can instead create a Schnorr signature container, and use that in place of MessageSignature in the block header, then I'll approve 👍

Done. Just working on adding "aggregate_public_key" to the RewardCycleInfo

[jferrant]

I am also inclined in this PR to update stacker_signature and all references to it to signers_signature as technically stackers may have offloaded their responsibilities to some other signer operator. Does anyone have objections to this? @jcnelson @kantai

[jcnelson]

Sounds good to me 👍

[CLAassistant]

All committers have signed the CLA.

[kantai]

LGTM -- I think we should just flag a relevant issue for the block that the agg key is fetched from, I don't think it needs to block this PR.

[blockstack-devops]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.