Feat/stacks signer block proposal

[jferrant]

Description

This is a rather large PR...please forgive.

major changes include:

• Complete reorg of the stacker db and stacks clients
• Complete reorg of the signer integration tests for easier adding of tests
• Changing libsigner to take SignerEvents rather than StackerDBEvents as we now need to subscribe to blocks
• Handling the new block proposal events within Stacks signer
• Added a test to handle a validated block (against the RPC endpoint)
• Enabled stackerdb_dkg_sign test as well since I made substantial changes to the test layout to ensure it still works

Applicable issues

• Closes Nokamoto[Block Proposal]: Signer binary handles BlockProposal event stored to StackerDB #3928
• Closes Nakamoto[Block Proposal]: Signer binary submits block proposal to stacks-node for validation #3929

Additional info (benefits, drawbacks, caveats)

Major items left to do that are NOT included in this PR

• State needs to be added to the signers to allow them to filter out already seen blocks requests/block validation responses/block sign requests. See [Nakamoto] stacks-signer needs track processed blocks responses, block requests, and block sign requests #4242
• Block is not properly deserialized during signing rounds to enable verification of a sign requests contents. See Nokamoto[Block Proposal]: Signer binary issues signature and broadcasts the block #3930
• State needs to be added to verify a block contains the expected transactions [Nakamoto] stacks-signer needs to track its transactions to verify a block contains these special cased transactions #4243

Checklist

• Test coverage for new or modified code paths
• Changelog is updated
• Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
• New clarity functions have corresponding PR in clarity-benchmarking repo
• New integration test(s) added to bitcoin-tests.yml

[codecov]

Codecov Report

Attention: 161 lines in your changes are missing coverage. Please review.

Comparison is base (15e76e5) 83.13% compared to head (52ccb11) 72.36%.

Files	Patch %	Lines
testnet/stacks-node/src/tests/signer.rs	79.20%	63 Missing ⚠️
stacks-signer/src/client/stackerdb.rs	69.62%	24 Missing ⚠️
libsigner/src/events.rs	65.15%	23 Missing ⚠️
stacks-signer/src/runloop.rs	83.05%	20 Missing ⚠️
stacks-signer/src/main.rs	0.00%	19 Missing ⚠️
libsigner/src/tests/mod.rs	86.95%	3 Missing ⚠️
stackslib/src/net/api/postblock_proposal.rs	85.00%	3 Missing ⚠️
stacks-signer/src/cli.rs	0.00%	2 Missing ⚠️
stacks-signer/src/client/stacks_client.rs	96.49%	2 Missing ⚠️
stacks-signer/src/client/mod.rs	93.75%	1 Missing ⚠️
... and 1 more

Additional details and impacted files

@@             Coverage Diff             @@
##             next    #4130       +/-   ##
===========================================
- Coverage   83.13%   72.36%   -10.77%     
===========================================
  Files         430      432        +2     
  Lines      306345   306587      +242     
===========================================
- Hits       254679   221867    -32812     
- Misses      51666    84720    +33054     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kantai]

This looks great to me, just had a few comments

[kantai]

LGTM!

[jcnelson]

Isn't this stackslib:: now, instead of blockstack_lib?

[jferrant]

I don't find it that way. as far as I am aware its still blockstack_lib. Can find no instance of stackslib::* throughout the code base.

[jcnelson]

Just a couple comments. Thanks!

[blockstack-devops]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.