feat: default to .signers boot contract in signer config
#4266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jferrant
approved these changes
Jan 19, 2024
hstove
force-pushed
the
feat/default-signerdb-config
branch
from
d46af99 to
ea77566
Compare
kantai
approved these changes
Jan 22, 2024
friedger
reviewed
Jan 24, 2024
| Some(id) => QualifiedContractIdentifier::parse(&id).map_err(|_| { | ||
| ConfigError::BadField("stackerdb_contract_id".to_string(), id.clone()) | ||
| })?, | ||
| None => boot_code_id("signers", raw_data.network == Network::Mainnet), |
There was a problem hiding this comment.
Is it an issue to run the signer against testnet?
There was a problem hiding this comment.
Nope, this is just setting the boot code address depending on the signer's config
hstove
force-pushed
the
feat/default-signerdb-config
branch
from
dafd97a to
5e7726d
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## next #4266 +/- ##
==========================================
- Coverage 83.41% 83.31% -0.10%
==========================================
Files 432 432
Lines 307438 307468 +30
==========================================
- Hits 256445 256172 -273
- Misses 50993 51296 +303 ☔ View full report in Codecov by Sentry. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small change makes the
stackerdb_contract_idconfig variable for the signer an optional field. When it isn't provided, it defaults toBOOT_CODE_ADDR.signers.Although all testing (unit and functional) is currently done with "mock" contracts, it might make sense to wait for #4263 before merging. We can also choose to merge this into that PR.