-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
warn for not using local stacks node with the signer #4782
Conversation
I think it could potentially cause more harm (or at least worry) than good if we're being strict about this warning with non-localhost setups. IMO it's probably best practice to have these two services on separate colocated machines, or at most using something like docker-compose, but we wouldn't really be able to check that. The main risk is that the signer isn't a registered event_observer, and that's easy to mess up if you're using an external node, but we don't have a good way of verifying that the signer is an event observer. |
Well the warning is mostly in response to the audit as we are susecptible to man in the middle type situations so perhaps we should just always print it then. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Current Status: Waiting for FAQ section to add link to.
Example display of message. Do we want to place it on only one line? Maybe make the message shorter.