Add vote for cli command #4934
Merged
Add vote for cli command #4934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacinta Ferrant <[email protected]>
jferrant
force-pushed
the
feature/vote-for-sip-cli
branch
from
793c6d0 to
d05c20b
Compare
Signed-off-by: Jacinta Ferrant <[email protected]>
kantai
reviewed
Jul 2, 2024
There was a problem hiding this comment.
This looks good to me, but I have a couple comments:
-
I think this should read the signing key from the config file like the signer binary does for running the signer.
-
This message format is fine, but I think it'd be better if it were a SIP-018 signing scheme.
… into feature/vote-for-sip-cli
Signed-off-by: Jacinta Ferrant <[email protected]>
I agree with both observations as it will make it consistent with generate stacking signature and remove the sha2 dependency. Done! |
kantai
reviewed
Jul 3, 2024
Signed-off-by: Jacinta Ferrant <[email protected]>
kantai
approved these changes
Jul 3, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two commands:
generate-vote: prints a vote signature across a SIP and vote value using the provided key
verify-vote: prints whether the message signature verifies against the provided info and public key
e.g. (Note PUBLIC_KEY, and SIGNATURE are in hexadecimal format)
stacks-signer generate-vote --sip 10 --vote yes -c [CONFIG_FILE]stacks-signer verify-vote --sip 10 --vote yes -p [PUBLIC_KEY] -s [SIGNATURE]QUESTION: There is mention of "How to Sign" Instructions being done as part of this PR. I assume this is in reference to "How to Vote" and would include the cli command documentation and then of course where you send your vote? not actually how to sign blocks?
Closes https://github.com/orgs/stacks-network/projects/63/views/32?pane=issue&itemId=68310304