Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass correct path to new_rpc_call_timer in get_tenure_forking_info #5275

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Pass correct path to new_rpc_call_timer in get_tenure_forking_info #5275

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7cdbac
Incorrect path was passed to new_rpc_call_timer calling out of bounds…
jferrant Oct 4, 2024
5b036df
Typo for Brice
jferrant Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions stacks-signer/src/client/stacks_client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,10 +376,12 @@ impl StacksClient {
"last_sortition" => %last_sortition,
);
let path = self.tenure_forking_info_path(chosen_parent, last_sortition);
let timer = crate::monitoring::new_rpc_call_timer(
"/v3/tenures/fork_info/:start/:stop",
&self.http_origin,
// Use a seperate metrics path to allow the same metric for different start and stop hashes
let metrics_path = format!(
"{}{RPC_TENURE_FORKING_INFO_PATH}/:start/:stop",
self.http_origin
);
let timer = crate::monitoring::new_rpc_call_timer(&metrics_path, &self.http_origin);
let send_request = || {
self.stacks_node_client
.get(&path)
Expand Down