Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/ci no tests full genesis test #5576

Merged
merged 5 commits into from
Dec 17, 2024
Merged

Conversation

jferrant
Copy link
Collaborator

@jferrant jferrant commented Dec 16, 2024

Closes #5554

Signed-off-by: Jacinta Ferrant <[email protected]>
jcnelson
jcnelson previously approved these changes Dec 16, 2024
@jferrant jferrant marked this pull request as ready for review December 16, 2024 19:23
@jferrant jferrant requested a review from a team as a code owner December 16, 2024 19:23
.github/workflows/stacks-core-tests.yml Outdated Show resolved Hide resolved
@jferrant jferrant dismissed jcnelson’s stale review December 16, 2024 19:53

The merge-base changed after approval.

@jferrant jferrant requested review from hstove and jcnelson December 16, 2024 20:12
obycode
obycode previously approved these changes Dec 16, 2024
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tests are failing? Just delete the tests -- problem solved! 😅

@obycode
Copy link
Contributor

obycode commented Dec 16, 2024

Are the jobs not running because of something wrong with this change?

@obycode
Copy link
Contributor

obycode commented Dec 16, 2024

Are the jobs not running because of something wrong with this change?

I just pushed a change that I think resolves that. 🤞

@jferrant jferrant requested a review from obycode December 16, 2024 21:45
@jferrant jferrant added this pull request to the merge queue Dec 17, 2024
Merged via the queue into develop with commit bf1e4f2 Dec 17, 2024
1 check passed
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Dec 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants