Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/use cargo workspace #5658

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Fix/use cargo workspace #5658

merged 1 commit into from
Jan 7, 2025

Conversation

rdeioris
Copy link
Contributor

@rdeioris rdeioris commented Jan 6, 2025

Description

This patch fixes the use of the cargo_workspace function in clarity_cli.rs.

This function is marked as "test only" in stacks_common::util so the use fails out of the testing context:

 Compiling stackslib v0.0.1 (/home/roberto/STACKS/STACKS_TESTS/stacks-core/stackslib)
error[E0432]: unresolved import `stacks_common::util::cargo_workspace`
  --> stackslib/src/clarity_cli.rs:38:27
   |
38 | use stacks_common::util::{cargo_workspace, get_epoch_time_ms, log};
   |                           ^^^^^^^^^^^^^^^ no `cargo_workspace` in `util`
   |

Applicable issues

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@rdeioris rdeioris changed the base branch from master to develop January 6, 2025 08:13
@rdeioris rdeioris marked this pull request as ready for review January 6, 2025 08:14
@rdeioris rdeioris requested a review from a team as a code owner January 6, 2025 08:14
Copy link
Contributor

@jbencin jbencin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why it was failing to compile before, but this is the proper place to put the use statement since it's only used in test code

@rdeioris rdeioris mentioned this pull request Jan 6, 2025
5 tasks
@aldur aldur added this to the 3.1.0.0.3 milestone Jan 7, 2025
@jcnelson jcnelson added this pull request to the merge queue Jan 7, 2025
Merged via the queue into develop with commit 4706d74 Jan 7, 2025
163 of 166 checks passed
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Status: Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

6 participants