Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added CreateOrEditTicket tickets function and added tests #1992

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

elraphty
Copy link
Contributor

@elraphty elraphty commented Nov 27, 2024

Describe your changes

This PR adds the create or edit tickets functionality and tests tickets function and added tests

Issue ticket number and link

Closes #1977
Closes #1978

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox

@elraphty elraphty marked this pull request as ready for review November 27, 2024 14:36
@aliraza556
Copy link
Contributor

Hi @elraphty, I have already created the ticket function. Please review it here:

https://github.com/stakwork/sphinx-tribes/blob/3798a3da96b5f283c4a38cc4f4e0976ce83b9b92/db/ticket_db.go#L35C1-L45C3

@elraphty elraphty merged commit 4c99272 into master Nov 27, 2024
2 checks passed
@elraphty
Copy link
Contributor Author

Hi @elraphty, I have already created the ticket function. Please review it here:

https://github.com/stakwork/sphinx-tribes/blob/3798a3da96b5f283c4a38cc4f4e0976ce83b9b92/db/ticket_db.go#L35C1-L45C3

That was not in your scope of work, I will review what you did an fix the merge conflicts.

@aliraza556
Copy link
Contributor

Hi @elraphty, I have already created the ticket function. Please review it here:
https://github.com/stakwork/sphinx-tribes/blob/3798a3da96b5f283c4a38cc4f4e0976ce83b9b92/db/ticket_db.go#L35C1-L45C3

That was not in your scope of work, I will review what you did an fix the merge conflicts.

@elraphty Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants