Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiling #968

Merged
merged 17 commits into from
Jan 18, 2021
Merged

Profiling #968

merged 17 commits into from
Jan 18, 2021

Conversation

rok-cesnovar
Copy link
Member

Summary:

Adds the profile_file argument that specifies a file in which to store profiling data.

Will fail until stan-dev/stanc3#794 is merged

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Rok Češnovar, Uni. of Ljubljana

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@rok-cesnovar rok-cesnovar mentioned this pull request Jan 16, 2021
16 tasks
Copy link
Member

@bbbales2 bbbales2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically looks good to me

src/cmdstan/command.hpp Show resolved Hide resolved
src/cmdstan/write_profiling.hpp Outdated Show resolved Hide resolved
src/cmdstan/write_profiling.hpp Outdated Show resolved Hide resolved
@bbbales2
Copy link
Member

I added a sig_figs thing

@stan-buildbot
Copy link
Contributor


Name Old Result New Result Ratio Performance change( 1 - new / old )
gp_pois_regr/gp_pois_regr.stan 3.36 3.36 1.0 0.03% faster
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.02 0.02 1.04 3.48% faster
eight_schools/eight_schools.stan 0.11 0.11 0.96 -4.16% slower
gp_regr/gp_regr.stan 0.15 0.15 1.0 -0.45% slower
irt_2pl/irt_2pl.stan 5.23 5.21 1.0 0.27% faster
performance.compilation 92.39 90.41 1.02 2.14% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 8.72 8.66 1.01 0.64% faster
pkpd/one_comp_mm_elim_abs.stan 28.9 28.83 1.0 0.25% faster
sir/sir.stan 132.47 127.82 1.04 3.51% faster
gp_regr/gen_gp_data.stan 0.04 0.04 0.98 -1.69% slower
low_dim_gauss_mix/low_dim_gauss_mix.stan 3.21 3.05 1.05 5.02% faster
pkpd/sim_one_comp_mm_elim_abs.stan 0.39 0.38 1.03 2.56% faster
arK/arK.stan 1.82 1.81 1.0 0.15% faster
arma/arma.stan 0.61 0.6 1.0 0.46% faster
garch/garch.stan 0.59 0.6 0.98 -2.35% slower
Mean result: 1.00715150837

Jenkins Console Log
Blue Ocean
Commit hash: d9f9262


Machine information ProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010

CPU:
Intel(R) Xeon(R) CPU E5-1680 v2 @ 3.00GHz

G++:
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Clang:
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

@rok-cesnovar rok-cesnovar requested a review from bbbales2 January 18, 2021 09:41
@stan-buildbot
Copy link
Contributor


Name Old Result New Result Ratio Performance change( 1 - new / old )
gp_pois_regr/gp_pois_regr.stan 3.41 3.39 1.0 0.45% faster
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.02 0.02 0.99 -1.31% slower
eight_schools/eight_schools.stan 0.12 0.11 1.01 0.6% faster
gp_regr/gp_regr.stan 0.15 0.15 1.0 -0.47% slower
irt_2pl/irt_2pl.stan 5.14 5.17 0.99 -0.64% slower
performance.compilation 91.21 89.87 1.01 1.46% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 8.74 8.93 0.98 -2.16% slower
pkpd/one_comp_mm_elim_abs.stan 29.97 30.13 0.99 -0.51% slower
sir/sir.stan 138.02 134.45 1.03 2.59% faster
gp_regr/gen_gp_data.stan 0.04 0.04 1.0 0.29% faster
low_dim_gauss_mix/low_dim_gauss_mix.stan 3.12 3.08 1.01 1.07% faster
pkpd/sim_one_comp_mm_elim_abs.stan 0.41 0.37 1.1 8.71% faster
arK/arK.stan 1.82 1.84 0.99 -1.38% slower
arma/arma.stan 0.62 0.6 1.03 2.88% faster
garch/garch.stan 0.59 0.6 0.99 -1.0% slower
Mean result: 1.00779325676

Jenkins Console Log
Blue Ocean
Commit hash: c89115e


Machine information ProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010

CPU:
Intel(R) Xeon(R) CPU E5-1680 v2 @ 3.00GHz

G++:
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Clang:
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Copy link
Member

@bbbales2 bbbales2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@rok-cesnovar rok-cesnovar merged commit 8e8d514 into develop Jan 18, 2021
@rok-cesnovar rok-cesnovar deleted the profiling_v2 branch January 18, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants