Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Summary
We implemented our json encoding based on the spec given in the Cmdstan Users Guide, which was incorrect. In particular, the value
"inf"
does not parse. The default values Python serializes these to does, so we should just leave it as it is.I also removed ujson as part of this fix. ujson implemented differing behavior from Python for infinity which meant round-tripping values was not possible. This was first noted in April of 2013, and did not get fixed until ujson 5.5.0 released last week. So, the options were either pin >=5.5.0, or just remove it.
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: