Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only check version URL after determining if it was already installed #673

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

WardBrian
Copy link
Member

Submission Checklist

  • Run unit tests
  • Declare copyright holder and open-source license: see below

Summary

Closes #672. This now only checks if the requested version is available after determining that the requested version is not already installed (e.g., right before we would try to download it).

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@WardBrian WardBrian added bug Something isn't working build download, install, and devops issues labels Jun 13, 2023
@WardBrian WardBrian requested a review from mitzimorris June 13, 2023 13:57
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2023

Codecov Report

Merging #673 (bafb7b1) into develop (7ad7dcc) will increase coverage by 0.47%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #673      +/-   ##
===========================================
+ Coverage    80.44%   80.92%   +0.47%     
===========================================
  Files           69       69              
  Lines        10653    10653              
===========================================
+ Hits          8570     8621      +51     
+ Misses        2083     2032      -51     

see 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@ahartikainen ahartikainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WardBrian WardBrian merged commit acd557f into develop Jun 13, 2023
@WardBrian WardBrian deleted the install/version-check-after-install branch June 13, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build download, install, and devops issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmdstanpy still attempts to contact github.com even when cmdstan is already installed
3 participants