Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "chain__", "iter__", and "draw__" columns to draws_pd #677

Merged
merged 4 commits into from
Jul 26, 2023

Conversation

WardBrian
Copy link
Member

@WardBrian WardBrian commented Jul 10, 2023

Submission Checklist

  • Run unit tests
  • Declare copyright holder and open-source license: see below

Summary

Closes #676

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@WardBrian WardBrian added the feature New feature or request label Jul 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2023

Codecov Report

Merging #677 (feed16c) into develop (1361f35) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #677      +/-   ##
===========================================
- Coverage    81.06%   80.99%   -0.07%     
===========================================
  Files           69       46      -23     
  Lines        10677     7152    -3525     
===========================================
- Hits          8655     5793    -2862     
+ Misses        2022     1359     -663     

see 27 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@WardBrian WardBrian requested a review from mitzimorris July 11, 2023 16:47
Copy link
Member

@mitzimorris mitzimorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@WardBrian WardBrian merged commit 7cf6483 into develop Jul 26, 2023
@WardBrian WardBrian deleted the feature/676-pandas-columns branch July 26, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

draws_pd() should include chain, iteration, and draw columns
3 participants