Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stan 2.33] Pathfinder #686

Merged
merged 21 commits into from
Sep 19, 2023
Merged

[Stan 2.33] Pathfinder #686

merged 21 commits into from
Sep 19, 2023

Conversation

WardBrian
Copy link
Member

@WardBrian WardBrian commented Aug 25, 2023

This PR is based on #681, which should be merged first.

Submission Checklist

  • Run unit tests
  • Declare copyright holder and open-source license: see below

Summary

Closes #684.

  • Adds a pathfinder method to CmdStanModel
  • Adds argument validation for Pathfinder, cleans up other validation
  • Add CmdStanPathfinder class with expected capabilities. Also improve CmdStanLaplace from [Stan 2.32] Laplace method and other changes #669

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@WardBrian WardBrian added the feature New feature or request label Aug 25, 2023
@WardBrian WardBrian linked an issue Aug 25, 2023 that may be closed by this pull request
@WardBrian
Copy link
Member Author

Note: #362 makes create_inits currently less easy to use, should be resolved

@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2023

Codecov Report

Merging #686 (fa307df) into develop (b55b276) will decrease coverage by 0.24%.
Report is 15 commits behind head on develop.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #686      +/-   ##
===========================================
- Coverage    80.03%   79.79%   -0.24%     
===========================================
  Files           72       75       +3     
  Lines        10953    11316     +363     
===========================================
+ Hits          8766     9030     +264     
- Misses        2187     2286      +99     

see 36 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@WardBrian
Copy link
Member Author

@mitzimorris @jgabry - I think this is essentially feature complete if we're happy with the interface from #684, mind starting to give it a glance?

Copy link
Member

@mitzimorris mitzimorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

cmdstanpy/cmdstan_args.py Outdated Show resolved Hide resolved
docsrc/api.rst Outdated Show resolved Hide resolved
cmdstanpy/stanfit/pathfinder.py Show resolved Hide resolved
@WardBrian WardBrian changed the title [WIP-Stan 2.33] Pathfinder [Stan 2.33] Pathfinder Sep 5, 2023
@WardBrian WardBrian marked this pull request as ready for review September 5, 2023 16:10
Base automatically changed from feature/tuple-io to develop September 5, 2023 16:15
@WardBrian
Copy link
Member Author

@jgabry do you mind giving this a glance just to confirm you're happy with the interface/names of things so cmdstanr can match?

@WardBrian
Copy link
Member Author

Jonah is busy this week so if @rok-cesnovar or @andrjohns could look at this and the design sketched in #684 for cmdstanr-parity reasons I'd appreciate it!

@WardBrian WardBrian mentioned this pull request Sep 11, 2023
2 tasks
@WardBrian WardBrian merged commit 13fe59f into develop Sep 19, 2023
@WardBrian WardBrian deleted the feature/pathfinder branch September 19, 2023 18:51
@mitzimorris
Copy link
Member

hooray!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Stan 2.33] Pathfinder algorithm
3 participants