-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Stan 2.33] Pathfinder #686
Conversation
Note: #362 makes |
Codecov Report
@@ Coverage Diff @@
## develop #686 +/- ##
===========================================
- Coverage 80.03% 79.79% -0.24%
===========================================
Files 72 75 +3
Lines 10953 11316 +363
===========================================
+ Hits 8766 9030 +264
- Misses 2187 2286 +99 see 36 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ed32773
to
5fde5dc
Compare
@mitzimorris @jgabry - I think this is essentially feature complete if we're happy with the interface from #684, mind starting to give it a glance? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
@jgabry do you mind giving this a glance just to confirm you're happy with the interface/names of things so cmdstanr can match? |
Jonah is busy this week so if @rok-cesnovar or @andrjohns could look at this and the design sketched in #684 for cmdstanr-parity reasons I'd appreciate it! |
hooray!!!! |
This PR is based on #681, which should be merged first.
Submission Checklist
Summary
Closes #684.
pathfinder
method to CmdStanModelCopyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: