Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix R cmd check note due to importance_sampling roxygen template #233

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

jgabry
Copy link
Member

@jgabry jgabry commented Nov 10, 2023

importance_sampling has argument method but was using a roxygen template for argument is_method leading to an r cmd check note.

@jgabry jgabry self-assigned this Nov 10, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #233 (9df7236) into master (69fa2f6) will not change coverage.
The diff coverage is 28.57%.

❗ Current head 9df7236 differs from pull request most recent head b85d1eb. Consider uploading reports for the commit b85d1eb to get more accurate results

@@           Coverage Diff           @@
##           master     #233   +/-   ##
=======================================
  Coverage   92.96%   92.96%           
=======================================
  Files          30       30           
  Lines        2770     2770           
=======================================
  Hits         2575     2575           
  Misses        195      195           
Files Coverage Δ
R/importance_sampling.R 84.04% <28.57%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@jgabry jgabry merged commit fc0cde9 into master Nov 10, 2023
6 checks passed
@jgabry jgabry deleted the fix-r-cmd-check-note branch November 10, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants