-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Closures prototype #1924
Closed
nhuurre
wants to merge
30
commits into
stan-dev:feature/parameter-pack-odes
from
nhuurre:closures-prototype
Closed
[WIP] Closures prototype #1924
nhuurre
wants to merge
30
commits into
stan-dev:feature/parameter-pack-odes
from
nhuurre:closures-prototype
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4.1 (tags/RELEASE_600/final)
…4.1 (tags/RELEASE_600/final)
…_latent_prob Add latent prob and latent rng functions for hmm
Generalize bernoulli distribution functions
…s/RELEASE_600/final)
@nhuurre variadic ODEs are in, does this have blockers still? |
@nhuurre Hey Niko, apologies it took me so long to get back to this, but is now a good time to work on this? It would be cool to get closures in for the next release (3 months from now). |
@SteveBronder Oh yeah I was one of the blockers lol. |
Superseded by #2094 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See the desing-doc stan-dev/design-docs#6 and the forum discussion https://discourse.mc-stan.org/t/closures-discussion/14932/
A proptotype autodiff interface for closures.
This builds on the variadic ODEs #1641
Checklist
Math issue: ???
Copyright holder: Niko Huurre
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
the basic tests are passing
./runTests.py test/unit
)make test-headers
)make test-math-dependencies
)make doxygen
)make cpplint
)the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested