Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Closures prototype #1924

Closed

Conversation

nhuurre
Copy link
Collaborator

@nhuurre nhuurre commented Jun 5, 2020

Summary

See the desing-doc stan-dev/design-docs#6 and the forum discussion https://discourse.mc-stan.org/t/closures-discussion/14932/

A proptotype autodiff interface for closures.

This builds on the variadic ODEs #1641

Checklist

  • Math issue: ???

  • Copyright holder: Niko Huurre

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)
  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

charlesm93 and others added 30 commits May 5, 2020 17:59
…_latent_prob

Add latent prob and latent rng functions for hmm
Generalize bernoulli distribution functions
@bbbales2 bbbales2 changed the base branch from develop to feature/parameter-pack-odes June 5, 2020 16:36
@SteveBronder
Copy link
Collaborator

@nhuurre variadic ODEs are in, does this have blockers still?

@bbbales2
Copy link
Member

@nhuurre Hey Niko, apologies it took me so long to get back to this, but is now a good time to work on this? It would be cool to get closures in for the next release (3 months from now).

@bbbales2
Copy link
Member

@SteveBronder Oh yeah I was one of the blockers lol.

@nhuurre
Copy link
Collaborator Author

nhuurre commented Sep 22, 2020

Superseded by #2094

@nhuurre nhuurre closed this Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants