Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split eigendecompose test for CI mem issues #2953

Merged
merged 1 commit into from
Oct 1, 2023

Conversation

andrjohns
Copy link
Collaborator

Summary

The windows CI checks are sporadically failing due to memory issues when compiling the eigendecompose mix test (see this run).

This PR just splits the test into two files to avoid this

Tests

N/A

Side Effects

N/A

Release notes

Split eigendecompose mix tests to fix CI memory issues

Checklist

  • Math issue #(issue number)

  • Copyright holder: Andrew Johnson

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)
  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

@andrjohns andrjohns merged commit 617ae34 into develop Oct 1, 2023
7 checks passed
@andrjohns andrjohns deleted the eigendecompose-test-split branch October 1, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants