Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing include guard for OpenCL rev headers #2996

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Conversation

andrjohns
Copy link
Collaborator

Summary

The stan/math/rev.hpp meta-header is missing the #ifdef STAN_OPENCL conditional includes for the OpenCL headers, which are present in the prim and fwd equivalents.

Tests

N/A

Side Effects

N/A

Release notes

Fixed missing include guard for OpenCL rev headers

Checklist

  • Copyright holder: Andrew Johnson

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)
  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

@WardBrian WardBrian merged commit 895f3e9 into develop Jan 4, 2024
8 checks passed
@WardBrian WardBrian deleted the opencl-rev-ifdef branch January 4, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants