-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/issue 2966 add 7 parameter ddm cdf and ccdf #3042
base: develop
Are you sure you want to change the base?
Feature/issue 2966 add 7 parameter ddm cdf and ccdf #3042
Conversation
…-7-parameter-DDM-CDF-and-CCDF merge PDF branch
merge develop with wiener_lpdf
Did commit early returns some ifs pass the tests? Or did that one fail from removing |
I checked out e5f5048 and added the test values from the prim wiener_lcdf tests here to the mix tests. All the mix tests that check against finite difference differentiation passed, but the prim test that checks the gradients you calculated do not pass. Where did you get the values of the true gradient values you use in the test in prim? It looks like the only code that changed in that commit were related to the gradient calculations so if they were incorrect I would expect the ad test suite to fail |
tbc what I made a branch to show what I did git pull
git checkout wiener_lpdf/test-vals
## These tests pass
python3 ./runTests.py -j20 ./test/unit/math/mix/prob/ -f wiener_full_lcdf
## Some of these tests fail
python3 ./runTests.py -j20 ./test/unit/math/prim/prob/ -f wiener_full_lc |
Only your suggested changes above for I changed the lines in
Now, all tests should pass. Let's see. Then, you can say, what I shall change next. |
This comment was marked as outdated.
This comment was marked as outdated.
Hey Steve, now the errors from before should be fixed and the wildcards are deleted. What next? |
Jenkins Console Log Machine informationNo LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: G++: Clang: |
Hey @SteveBronder, any news? |
Summary
With this PR the CDF and the CCDF of the 7-parameter diffuion model are added.
See issue #2966
Relates to issue #2822
Tests
We implemented analogous tests as for the PDF
Side Effects
no
Release notes
CDF and CCDF for the 7-parameter diffusion model. Allows modeling truncated and censored data.
Checklist
Copyright holder: Franziska Henrich, Christoph Klauer
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
the basic tests are passing
./runTests.py test/unit
)make test-headers
)make test-math-dependencies
)make doxygen
)make cpplint
)the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested