-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use a seperate class for csr_matrix adjoint #3053
Conversation
This one worked. I took @bgoodri’s provisional stanheaders that had our last attempt, dropped this file in, and rstanarm built on Windows |
OK. This is a fine workaround, although it is probably a bug in the C++ compiler or linker if we could come up with a minimal reproducible example. |
Perfect let me read this over one more time in the AM and we can merge. |
My first attempt at a reproducible example outside of the Stan codebase failed. It's still not entirely clear to me which ingredients are necessary to get the behavior |
Jenkins Console Log Machine informationNo LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: G++: Clang: |
@WardBrian added some docs, think this is good now |
Jenkins Console Log Machine informationNo LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: G++: Clang: |
Summary
Tries to fix the linking issue again in stan-dev/rstanarm#620
Tests
Same tests as before
@WardBrian or @bgoodri can you try using this version in stanheaders to see what happens?
Checklist
Copyright holder: (fill in copyright holder information)
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
the basic tests are passing
./runTests.py test/unit
)make test-headers
)make test-math-dependencies
)make doxygen
)make cpplint
)the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested