-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds constructor to vari for passing both initial values and adjoints #3089
Conversation
Jenkins Console Log Machine informationNo LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: G++: Clang: |
Summary
For a PR I'm doing in the Stan repo I need a constructor for
vari_value<Matrix>
types that accepts both the initial value and adjoint.This also changes the other constructors so that by default
vari_value<Matrix>
types are not put on the chainable stack. The var matrix type only needs it's chain called in thecallback_vari
type, but for all other purposes the matrix should actually not have it's chain method called. Instead it is normally called through a seperate emptyvari
made duringreverse_pass_callback()
Tests
Tests added that checks new constructor works and has the same pointer in the case the value and adjoint is the same matrix.
Release notes
Adds constructor to vari for passing initial values and adjoints
Checklist
Copyright holder: Simons Foundation
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
the basic tests are passing
./runTests.py test/unit
)make test-headers
)make test-math-dependencies
)make doxygen
)make cpplint
)the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested