Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to match CRAN's patched version #114

Merged
merged 1 commit into from
Jul 24, 2023
Merged

update to match CRAN's patched version #114

merged 1 commit into from
Jul 24, 2023

Conversation

jgabry
Copy link
Member

@jgabry jgabry commented Jul 23, 2023

CRAN notified me that they uploaded a new version of rstantools with the only difference being that when checking the version numbers of rstan and StanHeaders we now use strings instead of numerics (e.g. '2.26' instead of 2.26).

This PR updates the GitHub repo to match what CRAN did.

change version numbers from numeric to string
@jgabry jgabry requested review from bgoodri and andrjohns July 23, 2023 17:57
@jgabry
Copy link
Member Author

jgabry commented Jul 23, 2023

(forgot to mention that CRAN did this because they will eventually not allow numeric version numbers anymore and R-devel will already start warning about it)

@jgabry
Copy link
Member Author

jgabry commented Jul 24, 2023

Going to merge this since everything is passing and CRAN already made these changes

@jgabry jgabry merged commit 2f79789 into master Jul 24, 2023
@jgabry jgabry deleted the cran-patch branch July 24, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant