Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with .stanfunctions files #94

Merged
merged 2 commits into from
Mar 23, 2022
Merged

Add compatibility with .stanfunctions files #94

merged 2 commits into from
Mar 23, 2022

Conversation

andrjohns
Copy link
Collaborator

This PR adds the functionality needed for handling the .stanfunctions file type introduced in Stan 2.29 - which is essentially just a Stan file consisting solely of function definitions, but without the enclosing functions block.

As the included stanc3 is not directly compatible, this PR simply wraps the functions in a functions block, and treats the file like any other standalone-functions file to be exported

Copy link
Collaborator

@mcol mcol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nitpicks while passing by :)

R/rstan_config.R Outdated Show resolved Hide resolved
R/rstan_config.R Outdated Show resolved Hide resolved
@jgabry
Copy link
Member

jgabry commented Mar 10, 2022

Thanks @andrjohns and @mcol. This looks good to me. @bgoodri do you want to take a look at this?

@jgabry jgabry mentioned this pull request Mar 10, 2022
@jgabry jgabry merged commit 15db12e into stan-dev:master Mar 23, 2022
@hsbadr hsbadr mentioned this pull request Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants