Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Golf, ode case studies #194

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Update Golf, ode case studies #194

merged 2 commits into from
Sep 12, 2023

Conversation

WardBrian
Copy link
Member

  • Golf: Just re-knit
  • ODE: Text itself updated. Source updated here

@WardBrian WardBrian requested a review from jgabry September 12, 2023 18:54
@jgabry
Copy link
Member

jgabry commented Sep 12, 2023

These look good, except for one small thing in the golf html. When fitting some of the models (but not all, don't know why) we now get the following message:

code for methods in class "Rcpp_stan_fit4model11fb41afc2988_" was not checked for suspicious field assignments (recommended package 'codetools' not available?)

I don't get these messages when running the models, so I'm guessing this is some Rcpp thing that only shows up if you don't have the codetools package installed.

I can try generating the html and if it comes back clean I'll push it to this branch.

@jgabry
Copy link
Member

jgabry commented Sep 12, 2023

Ok yeah when I generated the html I didn't get those weird messages, presumably because I had codetools installed. I updated the branch and will merge now.

@jgabry jgabry merged commit 5e61ddf into master Sep 12, 2023
@jgabry jgabry deleted the bmw/case-studies-updates branch September 12, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants