Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case study: Estimating Dynamic Cross-National Opinion Using Existing Survey Data #195

Closed
wants to merge 4 commits into from

Conversation

cbpclaassen
Copy link

No description provided.

@jgabry jgabry changed the title fixes error in country labels Case study: Estimating Dynamic Cross-National Opinion Using Existing Survey Data Nov 22, 2023
Copy link
Member

@jgabry jgabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the one issue with the url (see review comment)

users/documentation/case-studies.md Outdated Show resolved Hide resolved
: latent variable models, public opinion, longitudinal model

Source Repository
: [example-models/knitr/dynamic-opinion](https://github.com/joonho112/example-models/tree/master/knitr/dynamic_opinion/estimating-dynamic-latent-opinion.html)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still getting an error even with this new link. It doesn't look like there's a dynamic-opinion folder inside joonho112/example-models/tree/master/knitr/.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed the url to my repo - maybe the path of least resistance?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay on this. The current URL I see is

https://github.com/joonho112/example-models/tree/master/knitr/dynamic_opinion/estimating-dynamic-latent-opinion.html

but this still gives me a 404 - page not found error. Is the URL right? Or is this a private repository maybe?

@cbpclaassen
Copy link
Author

cbpclaassen commented Nov 23, 2023 via email

@cbpclaassen
Copy link
Author

I've tried once more to push the files to your master repo. Probably did something wrong first time, sorry!

@cbpclaassen cbpclaassen requested a review from jgabry November 26, 2023 16:28
@bob-carpenter
Copy link

I've tried once more to push the files to your master repo. Probably did something wrong first time, sorry!

You won't have the necessary permissions to push to our repo. Plus, we don't want anyone pushing to master even if you do have permission---we do everything through pull requests. For this request, you can just keep the branch in your own repo and continue to update this pull request on your repo as needed to respond to comments. When it's ready to go, we just merge into stan-dev/stan-dev.github.io directly from your repo.

Plus, could you please add a description, even a one liner. Is this a new case study or an update to an existing one?

@jgabry
Copy link
Member

jgabry commented Dec 6, 2023

Closing (with author's permission) in favor of #196

@jgabry jgabry closed this Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants