Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give existing deprecations an expiration date #1044

Merged
merged 6 commits into from
Nov 19, 2021

Conversation

WardBrian
Copy link
Member

@WardBrian WardBrian commented Nov 18, 2021

This is the first of several PRs to begin the implementation of stan-dev/design-docs#43

This PR simply adds notice to all existing minor deprecations that they will be removed in Stan 2.32.0. This does not apply to the ODE integrators, only the syntax-level changes which can all be replaced with the canonicalizer.

Follow on PRs will:

  • Add warnings for 'future keywords': at the very least array (Incorrect parser errors on variable declarations #953), but also offset, multiplier, etc (basically re-doing Keywords should be reserved in Stan stan#2712)
  • Mark old array syntax as deprecated. This is already stated in the docs but currently produces no warnings.
    As part of this, I think we should run at least the auto-formatter on our test models, if not also the canonicalizer, to prevent the test output from ballooning due to all the old models.

Submission Checklist

Release notes

Marked existing syntax deprecations as expiring in Stan 2.32.0 in accordance with stan-dev/design-docs#43. Users should update their models (manually or with stanc --print-canonical) before that version of Stan.

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)

src/frontend/Deprecation_analysis.ml Outdated Show resolved Hide resolved
src/frontend/Deprecation_analysis.ml Outdated Show resolved Hide resolved
src/frontend/Deprecation_analysis.ml Show resolved Hide resolved
src/frontend/Deprecation_analysis.ml Outdated Show resolved Hide resolved
src/frontend/Warnings.ml Show resolved Hide resolved
@WardBrian
Copy link
Member Author

Bugs in the typechecker aside, I think this is good to go @nhuurre

@WardBrian WardBrian merged commit 88d5f33 into master Nov 19, 2021
@WardBrian WardBrian deleted the deprecation-timelines-existing branch November 19, 2021 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants