Give existing deprecations an expiration date #1044
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first of several PRs to begin the implementation of stan-dev/design-docs#43
This PR simply adds notice to all existing minor deprecations that they will be removed in Stan 2.32.0. This does not apply to the ODE integrators, only the syntax-level changes which can all be replaced with the canonicalizer.
Follow on PRs will:
array
(Incorrect parser errors on variable declarations #953), but alsooffset
,multiplier
, etc (basically re-doing Keywords should be reserved in Stan stan#2712)As part of this, I think we should run at least the auto-formatter on our test models, if not also the canonicalizer, to prevent the test output from ballooning due to all the old models.
Submission Checklist
Release notes
Marked existing syntax deprecations as expiring in Stan 2.32.0 in accordance with stan-dev/design-docs#43. Users should update their models (manually or with
stanc --print-canonical
) before that version of Stan.Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)