Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly verify a variable name isn't in use #1061

Merged
merged 2 commits into from
Nov 26, 2021
Merged

Conversation

WardBrian
Copy link
Member

Silly mistake on my part when merging the symbol table in #995. Realized it would be a 1 line fix so I decided not to wait @rok-cesnovar.

Closes #1060

Submission Checklist

  • Run unit tests
  • Documentation
    • OR, no user-facing changes were made

Release notes

Fixes a bug not in the last release (#1060)

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)

Copy link
Member

@rok-cesnovar rok-cesnovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Also tested that all models in the issue work fine now.

Thanks!

@rok-cesnovar rok-cesnovar merged commit 5cdfd41 into master Nov 26, 2021
@rok-cesnovar rok-cesnovar deleted the var-fresh-fix branch November 26, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with duplicated use of variable named e (or other name shadowing nullary functions)
2 participants