Deduplicate logic in UnsizedType and Signaturemismatch #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WardBrian
force-pushed
the
dedupe-unsized-signaturemismatch
branch
from
b15dd75 to
704dc9b
Compare
WardBrian
force-pushed
the
dedupe-unsized-signaturemismatch
branch
from
704dc9b to
62328b8
Compare
WardBrian
changed the title
WardBrian
requested review from
nhuurre and
SteveBronder
and removed request for
nhuurre
|
Since #1102 is merged this is next on the list of refactors which help out complex matrices, and I think it should be ready for review. |
nhuurre
reviewed
Feb 17, 2022
nhuurre
reviewed
Feb 18, 2022
nhuurre
approved these changes
Feb 18, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1001.
This depends on #1102 and #1114, so the diff will be much nicer after those are merged. I'm marking it as a draft for now just so I can confirm tests pass
Submission Checklist
Release notes
Internal refactoring
Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)