Disable inlining for transformed data #1218
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #1097. The 0-size objects created by the function inliner fail in
transformed data
at runtime. The error looks like:For now this PR simply disables the function inliner in the
prepare_data
section. @SteveBronder might have a more clever fix, but this is low priority since optimizing transformed data is less useful than most of the rest of the model which gets called repeatedly.I added a test
test/integration/good/compiler-optimizations/inline-tdata.stan
, but since the failure is at runtime we should really put this in something used by performance-tests-cmdstan (@rok-cesnovar). I've confirmed locally that the model fails againstmaster
but works after this PR.Submission Checklist
Release notes
Function in-lining fails at runtime in
transformed data
and has been disabled in that block for now.Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)