Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added context standardEnabled #106

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Added context standardEnabled #106

merged 1 commit into from
Apr 30, 2020

Conversation

tinchoz49
Copy link
Contributor

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix
[x ] New feature
[ ] Other, please explain:

What changes did you make? (Give an overview)

I added a clause context to detect if standard is enabled.

Now for example we can use the context in our key bindings, e.g:

{
    "key": "ctrl+shift+i",
    "command": "standard.executeAutofix",
    "when": "standardEnabled && editorTextFocus && !editorReadonly"
}

Copy link
Member

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat 👍

@tinchoz49
Copy link
Contributor Author

Hey @LinusU how are you?

do you know when we can have this PR published?

@LinusU
Copy link
Member

LinusU commented Apr 30, 2020

Hey @tinchoz49 👋 Just good! How are you?

Unfortunately, I don't have access to publish this module to the VS Code market place.

I can merge this and upload a a .vsix that you can install manually for now. I'll also create a separate issue about getting access.

@LinusU LinusU merged commit 66416be into standard:master Apr 30, 2020
@tinchoz49
Copy link
Contributor Author

Oh, I didn't know. The .vsix is great for now, thanks!!

@LinusU
Copy link
Member

LinusU commented Apr 30, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants