feat: better options default

[theoludwig]

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix
[x] New feature
[ ] Other, please explain:

What changes did you make? (Give an overview)

As explained in #261, this PR reduce configurations overhead for users so that they can use the extension fast without too much configurations and still following "best practices" by encouraging local installation per project.

This PR adds a new option "standard.enableGlobally" (false by default) to enable the extension for all files even if there is no engines installed in package.json in devDependencies.

Which issue (if any) does this pull request address?

Fixes #261

Is there anything you'd like reviewers to focus on?

BREAKING CHANGE: This feature changed the default settings, before: "standard.usePackageJson": false, after: "standard.usePackageJson": true

BREAKING CHANGE: By default (if you don't set "standard.enableGlobally": true), the extension will not lint your files if you haven't got a package.json containing one of the engines installed in devDependencies.

(Easily fixable by editing .vscode/settings.json, long time ago we didn't have BREAKING CHANGE for this extension so that should be fine)

[theoludwig]

I left some comments on why I did certain things.

[theoludwig]

We don't need to disable this setting while using this extension, and I would encourage to enable it so you can get both linting and javascript errors.

[theoludwig]

What about making easier for the user to install the extension instead of redirecting them to the documentation ?

We're still redirecting them to the documentation if they want more information.

[theoludwig]

To make it consistent, we use the word Extension instead of Plugin, it means the same thing in this context.

[LinusU]

Hmm, won't this turn off standard linting for anyone currently using the extension, when upgrading to this version? 🤔

[theoludwig]

Yes, that's why it is a BREAKING CHANGE.

I don't think it is a great idea to enable standard linting by default globally, it should be enabled by each project individually so if one project use eslint instead of standard engines, it doesn't conflict.

Maybe we can do better ?
We can detect if one of the engines (standard, semistandard, standardx or ts-standard) is installed in devDependencies if so we enable the extension?
That way we don't need any settings in.vscode/settings.json, it just works out of the box (as one of standard goals).
What do you think?

[voxpelli]

I think there should be three levels:

1. Globally enabled
2. Globally disabled
3. Globally enabled in projects that has a recognizable standard setup

And the default should be the third option in my opinion.

Edit: But I have no knowledge how this is currently set up, just wanted to add my thoughts on the desired state

[theoludwig]

I agree too the default should be the third option, so we don't need any settings to use this extension by default. 👍

Currently, the extension is working by default with the first option (Globally enabled), this PR was trying to make it work like the second option (Globally disabled).

When I will have some time, I will update the PR to make it work like the third option.
Thanks for making it clearer! 😄

[theoludwig]

Done! I updated the PR.

Also, I added in CHANGELOG.md what changed and bump the version number to 2.0.0, so we can release a new version after this PR has been merged.
See CHANGELOG.md for an explanation about the new behavior.

[LinusU]

🚀