Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #139 .
This PR moves us to depend on rubocop 0.75, in order to catch bug fixes. The one I'm specifically interested in is rubocop/rubocop#7170, but i thought it might be helpful to get us all the way up to date.
Changes required:
Performance/Count
andPerformance/Detect
, as these were marked as removed. they were removed inrubocop-performance v1.5.0
(see Performance Count Cop does not work rubocop/rubocop-performance#69 (comment) for details), and marked as removed in Change warning location ofSafeMode
rubocop/rubocop#7341test/standard/runners/rubocop_test.rb
. To my untrained eye, the changes do not seem semantically meaningful.If we are concerned about the changes necessary to get the move to 0.75 to work, happy to revert those and only bump to 0.74.
Thanks!