Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumpb rubocop version to 0.75 #140

Merged
merged 3 commits into from
Oct 18, 2019
Merged

Conversation

raorao
Copy link
Contributor

@raorao raorao commented Oct 11, 2019

issue: #139 .

This PR moves us to depend on rubocop 0.75, in order to catch bug fixes. The one I'm specifically interested in is rubocop/rubocop#7170, but i thought it might be helpful to get us all the way up to date.

Changes required:

  • nothing required to move from 0.72 -> 0.73 (test suite passed with no issue)
  • nothing required to move from 0.73 -> 0.74 (test suite passed with no issue)
  • following changes required to move from 0.74 -> 0.75:

If we are concerned about the changes necessary to get the move to 0.75 to work, happy to revert those and only bump to 0.74.

Thanks!

Copy link

@majormoses majormoses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@searls searls merged commit e14f233 into standardrb:master Oct 18, 2019
@searls
Copy link
Contributor

searls commented Oct 18, 2019

Landed in 0.1.5

Note that writing "Fixes #139" or "Resolves #139" in the comment of a PR will automatically close a tagged issue upon merge of the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants