Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bfloat16 is another 16-bit floating point format which has the same number of exponent bits as
f32
, making conversion to/fromf32
much faster. This PR would add support for bfloat16 floats to the crate.I'm not sure if there is interest in adding this to the half crate, but since the code is basically a tweaked version of the
f16
code, I thought it made sense to add it to the crate.I'm also not sure about the names. I just prepended
b
tof16
,consts
,slice
andvec
to getbf16
,bconsts
,bslice
andbvec
. It looks fine to me, but maybe it makes more sense to keepbf16
but move the others tobfloat::consts
,bfloat::slice
andbfloat::vec
, I don't know.