no snapshot peeling from type_enriched_members key.

[ilyalesokhin-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[ilyalesokhin-starkware]

crates/cairo-lang-semantic/src/diagnostic_test_data/deref line 206 at r1 (raw file):

//! > function_body

//! > expected_diagnostics

Before the fix.

because it assumed @s3 has the same deref as S3.

Suggestion:

//! > expected_diagnostics
error: Unexpected argument type. Expected: "test::S3", found: "@test::S3".
 --> lib.cairo:46:6
    (@s3).a;
     ^^^

[orizi]

Reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware and @ilyalesokhin-starkware)

---

crates/cairo-lang-semantic/src/expr/compute.rs line 3073 at r1 (raw file):

            ctx.resolver.inference().solve().ok();
            ctx.resolver.inference().internal_rewrite(&mut long_ty).no_err();
            let members =

shouldn't the key be rewritten as well?

Code quote:

            let (_, mut long_ty) = peel_snapshots(ctx.db, expr.ty());
            // Save some work. ignore the result. The error, if any, will be reported later.
            ctx.resolver.inference().solve().ok();
            ctx.resolver.inference().internal_rewrite(&mut long_ty).no_err();
            let members =

[ilyalesokhin-starkware]

crates/cairo-lang-semantic/src/expr/compute.rs line 3073 at r1 (raw file):

Previously, orizi wrote…

shouldn't the key be rewritten as well?

I don't now if you are more likely to look for the original key or the rewritten key.

[orizi]

Reviewed 1 of 2 files at r1.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware and @ilyalesokhin-starkware)

---

crates/cairo-lang-semantic/src/expr/compute.rs line 3073 at r1 (raw file):

Previously, ilyalesokhin-starkware wrote…

I don't now if you are more likely to look for the original key or the rewritten key.

probably the rewritten - as you'd probably have the most "solved" possible value for this lookup.

[orizi]

Reviewed 1 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware and @ilyalesokhin-starkware)

[ilyalesokhin-starkware]

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @gilbens-starkware and @orizi)

---

crates/cairo-lang-semantic/src/expr/compute.rs line 3073 at r1 (raw file):

Previously, orizi wrote…

probably the rewritten - as you'd probably have the most "solved" possible value for this lookup.

Done.

[orizi]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gilbens-starkware)

[gilbens-starkware]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)

[ilyalesokhin-starkware]

Reviewed 1 of 2 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ilyalesokhin-starkware)