feat: Expand kubectl direct watching to support heterogeneous use cases

This PR updates the duration over which red badges flash from 6 cycles down to 3.

This PR also works around an issue in globby. sindresorhus/globby#166

Fixes kubernetes-sigs#6504

packages/test/src/api/table.ts

@@ -208,7 +208,7 @@ export class TestTable {
             selector: Selectors.TABLE_HEADER_CELL(expectTable.header.name)
           })
         )
-        .catch(Common.oops(ctx)))
+        .catch(Common.oops(ctx, true)))
 
     if (validation) {
       if (validation.cells) {
@@ -251,7 +251,8 @@ export class TestTable {
           const cell = await ctx.app.client.$(
             `${Selectors.OUTPUT_N(self.cmdIdx)} ${Selectors.TABLE_CELL(row.name, expectTable.header.name)}`
           )
-          await cell.waitForExist()
+          await cell.waitForExist({ timeout: 10000 })
+          await cell.scrollIntoView()
           await cell.click()
           await CLI.expectPriorInput(prompt, command)(ctx.app)
         } catch (err) {

plugins/plugin-bash-like/fs/src/lib/glob.ts

@@ -94,7 +94,7 @@ async function isDir(filepath: string): Promise<Stats> {
   return new Promise((resolve, reject) => {
     stat(filepath, (err, stats) => {
       if (err) {
-        if (err.code === 'ENOENT') {
+        if (err.code === 'ENOENT' || err.code === 'ENOTDIR') {
           resolve(undefined)
         } else {
           reject(err)
@@ -168,14 +168,16 @@ export async function kuiglob({
   const globbedEntries =
     toGlob.length === 0 && inputs.length > 0
       ? []
-      : ((await globby(toGlob.length === 0 ? '*' : toGlob, {
-          followSymbolicLinks: false,
+      : (((await globby(toGlob.length === 0 ? ['*'] : toGlob, {
           onlyFiles: false,
+          suppressErrors: true,
+          expandDirectories: false, // see https://github.com/sindresorhus/globby/issues/166
+          followSymbolicLinks: false,
           dot: parsedOptions.a || parsedOptions.all,
           stats: needStats,
           objectMode: !needStats,
           cwd: isHeadless() ? process.cwd() : tab.state.cwd
-        })) as RawGlobStats[])
+        })) as any) as RawGlobStats[])
   //  ^^^^^^ re: type conversion; globby type declaration issue #139
 
   // handle -d; fast-glob doesn't seem to handle this very well on its

plugins/plugin-client-common/web/scss/components/Table/badges.scss

@@ -169,8 +169,8 @@ $grid-cell-size: 1.25rem;
     }
 
     &.red-background {
-      /* if it's red, then blink around 6 times */
-      animation: var(--animation-medium-repeating-pulse);
+      /* if it's red, then blink around 3 times */
+      animation: var(--animation-short-repeating-pulse);
     }
   }
 }

plugins/plugin-ibmcloud/plugin/src/controller/available.ts

@@ -30,7 +30,7 @@ export default async function getAvailablePlugins(
   tab: Tab,
   url = defaultURL
 ): Promise<{ plugins: AvailablePluginRaw[] }> {
-  return JSON.parse((await fetchFileString(tab.REPL, `${url}/plugins`))[0])
+  return JSON.parse((await fetchFileString(tab.REPL, `${url}/plugins`))[0] || '{ "plugins": [] }')
 }
 
 /**

plugins/plugin-kubectl-flow-views/tekton/src/lib/read.ts

@@ -38,7 +38,7 @@ export const parse = async (raw: string | PromiseLike<string>): Promise<KubeReso
  */
 export const read = async (tab: Tab, filepath: string): Promise<string> => {
   const data = await fetchFileString(tab.REPL, filepath)
-  if (data.length === 1) {
+  if (data.length === 1 && data[0]) {
     return data[0]
   } else {
     throw new Error(`Failed to fetch ${filepath}`)

plugins/plugin-kubectl/src/controller/client/direct/404.ts

@@ -0,0 +1,40 @@
+/*
+ * Copyright 2020 IBM Corporation
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { Row, Table } from '@kui-shell/core'
+
+import { rowWith, standardStatusHeader } from './unify'
+import TrafficLight from '../../../lib/model/traffic-light'
+
+/**
+ * @return a Row for the given name in `names` with an Offline status.
+ *
+ */
+function fabricate404Row(name: string, kind: string): Row {
+  return rowWith(name, kind, 'Offline', TrafficLight.Red)
+}
+
+/**
+ * @return a Table with one row per given name in `names`, each row
+ * with an Offline status.
+ *
+ */
+export default function fabricate404Table(names: string[], kind: string): Table {
+  return {
+    header: standardStatusHeader,
+    body: names.map(name => fabricate404Row(name, kind))
+  }
+}

plugins/plugin-kubectl/src/controller/client/direct/create.ts

@@ -98,7 +98,9 @@ export default async function createDirect(
         ]
 
         const watchPart = await status(args, groups, FinalState.OnlineLike)
-        return withErrors(watchPart, errors)
+        if (watchPart) {
+          return withErrors(watchPart, errors)
+        }
       }
     }
   }