Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nimbus: mark branches supporting BN light client server #90

Merged
merged 1 commit into from
Mar 25, 2022
Merged

nimbus: mark branches supporting BN light client server #90

merged 1 commit into from
Mar 25, 2022

Conversation

etan-status
Copy link
Contributor

The idea here is to conditionally enable support for the new light client server arguments depending on whether the node is using a repo branch that supports the corresponding launch arguments.

@etan-status etan-status requested a review from jakubgs March 25, 2022 15:22
@etan-status etan-status marked this pull request as ready for review March 25, 2022 15:24
jakubgs
jakubgs reviewed Mar 25, 2022
View reviewed changes
ansible/group_vars/all.yml Outdated Show resolved Hide resolved
@etan-status
Copy link
Contributor Author

  • Moved variables from all.yml to fleet specific files.

@etan-status
Copy link
Contributor Author

  • Use default config for kiln config.

jakubgs
jakubgs approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member

@jakubgs jakubgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

@jakubgs
Copy link
Member

jakubgs commented Mar 25, 2022

Tested on Pyrmont hosts:

[email protected]:~ % s cat beacon-node-pyrmont-stable.service | grep light  
[email protected]:~ % s cat beacon-node-pyrmont-unstable.service | grep light
    --serve-light-client-data=false \
    --import-light-client-data=none \

Looks good.

@jakubgs jakubgs merged commit c0630ae into status-im:master Mar 25, 2022
@jakubgs
Copy link
Member

jakubgs commented Mar 25, 2022

Deployed to Prater:

  > a nimbus.prater -a 'systemctl cat "beacon-node-prater-unstable*" | grep light'       
metal-02.he-eu-hel1.nimbus.prater | CHANGED | rc=0 >>
    --serve-light-client-data=false \
    --import-light-client-data=none \
metal-03.he-eu-hel1.nimbus.prater | CHANGED | rc=0 >>
    --serve-light-client-data=false \
    --import-light-client-data=none \
metal-06.he-eu-hel1.nimbus.prater | CHANGED | rc=0 >>
    --serve-light-client-data=false \
    --import-light-client-data=none \
metal-01.he-eu-hel1.nimbus.prater | CHANGED | rc=0 >>
    --serve-light-client-data=false \
    --import-light-client-data=none \
metal-05.he-eu-hel1.nimbus.prater | CHANGED | rc=0 >>
    --serve-light-client-data=false \
    --import-light-client-data=none \
metal-04.he-eu-hel1.nimbus.prater | CHANGED | rc=0 >>
    --serve-light-client-data=false \
    --import-light-client-data=none \
unstable-large-01.aws-eu-central-1a.nimbus.prater | CHANGED | rc=0 >>
    --serve-light-client-data=false \
    --import-light-client-data=none \

@jakubgs
Copy link
Member

jakubgs commented Mar 25, 2022

And mainnet:

 > a nimbus.mainnet -a 'systemctl cat "beacon-node-mainnet-unstable*" | grep light'      
metal-06.he-eu-hel1.nimbus.mainnet | CHANGED | rc=0 >>
    --serve-light-client-data=false \
    --import-light-client-data=none \
    --serve-light-client-data=false \
    --import-light-client-data=none \
metal-03.he-eu-hel1.nimbus.mainnet | CHANGED | rc=0 >>
    --serve-light-client-data=false \
    --import-light-client-data=none \
    --serve-light-client-data=false \
    --import-light-client-data=none \
metal-05.he-eu-hel1.nimbus.mainnet | CHANGED | rc=0 >>
    --serve-light-client-data=false \
    --import-light-client-data=none \
    --serve-light-client-data=false \
    --import-light-client-data=none \
metal-02.he-eu-hel1.nimbus.mainnet | CHANGED | rc=0 >>
    --serve-light-client-data=false \
    --import-light-client-data=none \
    --serve-light-client-data=false \
    --import-light-client-data=none \
metal-01.he-eu-hel1.nimbus.mainnet | CHANGED | rc=0 >>
    --serve-light-client-data=false \
    --import-light-client-data=none \
    --serve-light-client-data=false \
    --import-light-client-data=none \
metal-04.he-eu-hel1.nimbus.mainnet | CHANGED | rc=0 >>
    --serve-light-client-data=false \
    --import-light-client-data=none \
    --serve-light-client-data=false \
    --import-light-client-data=none \

@etan-status etan-status deleted the lc-support branch March 28, 2022 06:41
@etan-status etan-status mentioned this pull request Mar 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubgs jakubgs jakubgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etan-status @jakubgs