Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvstore: return bool from del, add clear #574

Merged
merged 2 commits into from
Jan 3, 2023
Merged

kvstore: return bool from del, add clear #574

merged 2 commits into from
Jan 3, 2023

Conversation

arnetheduck
Copy link
Member

This allows making decisions based on whether an element was present during the del

@arnetheduck
kvstore: return bool from del, add clear
b6b575c 
This allows making decisions based on whether an element was present
during the `del`
@arnetheduck arnetheduck mentioned this pull request Dec 23, 2022
Merged
kdeme
kdeme reviewed Jan 2, 2023
View reviewed changes
eth/db/kvstore_sqlite3.nim Outdated Show resolved Hide resolved
eth/db/kvstore.nim Outdated Show resolved Hide resolved
@arnetheduck arnetheduck merged commit 8f0ae55 into master Jan 3, 2023
@arnetheduck arnetheduck deleted the kvstore-clear branch January 3, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdeme kdeme kdeme left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arnetheduck @kdeme