Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle new UPnP return value #728

Merged
merged 1 commit into from
Sep 10, 2024
Merged

handle new UPnP return value #728

merged 1 commit into from
Sep 10, 2024

Conversation

tersec
Copy link
Contributor

@tersec tersec commented Sep 10, 2024

@tersec
Copy link
Contributor Author

tersec commented Sep 10, 2024

devel build errors are due to nim-lang/Nim#24090

[NimScript] exec: nim c  --styleCheck:usages --styleCheck:error --verbosity:0 --hints:off --skipUserCfg --nimcache:build/nimcache -f --warning[ObservableStores]:off -d:nimOldCaseObjects -d:chronicles_log_level=TRACE --threads:on -d:release  --mm:refc -r --outdir:build/p2p tests/p2p/all_tests
/home/runner/work/nim-eth/nim-eth/tests/p2p/test_enr.nim(22, 1) template/generic instantiation of `suite` from here
/home/runner/work/nim-eth/nim-eth/tests/p2p/test_enr.nim(51, 3) template/generic instantiation of `test` from here
/home/runner/.nimble/pkgs2/unittest2-0.2.2-6ac7f7ea74df812a25be5d6d36a59d23789eb508/unittest2.nim(1127, 24) template/generic instantiation of `failingOnExceptions` from here
/home/runner/.nimble/pkgs2/unittest2-0.2.2-6ac7f7ea74df812a25be5d6d36a59d23789eb508/unittest2.nim(1131, 26) template/generic instantiation of `failingOnExceptions` from here
/home/runner/work/nim-eth/nim-eth/tests/p2p/test_enr.nim(55, 19) Error: cannot instantiate: 'Opt[T]'; Maybe generic arguments are missing?

@tersec tersec merged commit 11eafac into master Sep 10, 2024
10 of 15 checks passed
@tersec tersec deleted the lOy branch September 10, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant