Bump libp2p (GossipSub improvements) #3112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the latest libp2p unstable merge: vacp2p/nim-libp2p#651
Relevant for nimbus:
vacp2p/nim-libp2p#634: allow applications to tune the maximum GossipSub message size, and switch default to 1Mb
vacp2p/nim-libp2p#648: Fix an issue where we relayed GossipSub messages to the peer who sent it to us. This reduce the number of message sent by about ~10%
Also, we'll avoid relaying messages to peers who sent the message while we are validating it. Currently, with validation in nimbus being near instantaneous, the effect is negligible on beefy servers (about 1% reduction in sent messages). But on more restricted nodes, it will have a bigger impact.
More importantly, this opens the opportunity to optimize the uplink traffic (and replication level in the network) even more, by waiting longer during validation