Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serve light client data on prater by default #3559

Merged
merged 1 commit into from
Apr 1, 2022
Merged

serve light client data on prater by default #3559

merged 1 commit into from
Apr 1, 2022

Conversation

etan-status
Copy link
Contributor

Applies a prater testnet specific config default to serve light client
data on that network.

@etan-status
Copy link
Contributor Author

Followup from status-im/infra-nimbus#91

etan-status
etan-status commented Mar 30, 2022
View reviewed changes
beacon_chain/networking/network_metadata.nim Outdated
@@ -143,14 +153,29 @@ proc loadEth2NetworkMetadata*(path: string, eth1Network = none(Eth1Network)): Et
else:
""

configDefaults =
if path.endsWith("/prater"):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tersec : When merging this to kiln-dev-auth, please also add /kiln here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e88bc1b

@etan-status etan-status marked this pull request as draft March 30, 2022 12:26
@etan-status etan-status mentioned this pull request Mar 30, 2022
Closed
@etan-status etan-status force-pushed the dev/etan/lc-praterdefaults branch from 7256ef0 to e95a99b Compare March 30, 2022 12:58
@etan-status
Copy link
Contributor Author

  • Fix test suite

@etan-status etan-status marked this pull request as ready for review March 30, 2022 14:51
@github-actions
Copy link

github-actions bot commented Mar 30, 2022 •
edited
Loading

Unit Test Results

     12 files  ±0     834 suites  ±0   59m 44s ⏱️ + 11m 17s
1 686 tests ±0  1 638 ✔️ ±0    48 💤 ±0  0 ❌ ±0 
9 825 runs  ±0  9 713 ✔️ ±0  112 💤 ±0  0 ❌ ±0 

Results for commit c06b9f4. ± Comparison against base commit a18b39c.

♻️ This comment has been updated with latest results.

@tersec
Copy link
Contributor

tersec commented Apr 1, 2022

A general note/caveat: while there are a number of locally-unprotected gets here, the BN-based codepaths look okay, and while there are design alternatives to this approach, they have their own tradeoffs.

@etan-status
serve light client data on prater by default
c06b9f4 
Applies a `prater` testnet specific config default to serve light client
data on that network.
@etan-status etan-status force-pushed the dev/etan/lc-praterdefaults branch from e95a99b to c06b9f4 Compare April 1, 2022 18:20
@etan-status
Copy link
Contributor Author

  • Use first 40 bytes of genesisData (genesis_time and genesis_validators_root) to identify network instead of --network folder name.

@etan-status etan-status merged commit 509aa6c into unstable Apr 1, 2022
@etan-status etan-status deleted the dev/etan/lc-praterdefaults branch April 1, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tersec tersec tersec approved these changes

@zah zah zah left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@etan-status @tersec @zah