Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge LC db into main BN db #3832

Merged
merged 2 commits into from
Jul 4, 2022
Merged

merge LC db into main BN db #3832

merged 2 commits into from
Jul 4, 2022

Conversation

etan-status
Copy link
Contributor

To treat derived LC data similar to derived state caches, merge it into
the main beacon node DB.

To treat derived LC data similar to derived state caches, merge it into
the main beacon node DB.
@github-actions
Copy link

github-actions bot commented Jul 1, 2022

Unit Test Results

     12 files  ±0     857 suites  ±0   1h 7m 28s ⏱️ + 3m 42s
1 712 tests ±0  1 660 ✔️ ±0    52 💤 ±0  0 ±0 
9 944 runs  ±0  9 816 ✔️ ±0  128 💤 ±0  0 ±0 

Results for commit 568a4ba. ± Comparison against base commit 499abd9.

♻️ This comment has been updated with latest results.

@etan-status
Copy link
Contributor Author

Note that this will create the new LC tables even when LC data collection is disabled (they won't be populated though), because BeaconChainDB does not know about the config. Not sure if that's a problem, or if we should pass that info in there as well.

@etan-status
Copy link
Contributor Author

Screenshot 2022-07-01 at 08 17 02

@zah zah marked this pull request as ready for review July 4, 2022 20:46
@zah zah merged commit aff53e9 into unstable Jul 4, 2022
@zah zah deleted the dev/etan/lc-db2 branch July 4, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants