[Keymanager API] Support for the feerecipient end-points #3864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other changes: * The Keymanager error responses differ from the Beacon API responses. 'keymanagerApiError' replaces the former usages of 'jsonError'. * Return status code 401 and 403 for authorization errors in accordance to the spec. * Eliminate inconsistencies in the REST JSON parsing. Some of the code paths allowed missing fields. * Added logging of serialization failure details at DEBUG level.
zah
force-pushed
the
keymanager-fee-recipient
branch
from
b898dbb to
c1fea49
Compare
etan-status
added a commit
that referenced
this pull request
Jul 13, 2022
#3864 introduced a regression by turning on `requireAllFields` globally for JSON parsing. Certain endpoints such as `RestSyncInfo` have optional fields that do not parse correctly without additional changes. As this change was neither reviewed nor passed unit tests, reverting for now.
etan-status
added a commit
that referenced
this pull request
Jul 14, 2022
#3864 introduced a regression by turning on `requireAllFields` globally for JSON parsing. Certain endpoints such as `RestSyncInfo` have optional fields that do not parse correctly without additional changes. This is reverted for now to restore previous behaviour and unblock CI testing.
etan-status
added a commit
that referenced
this pull request
Jul 14, 2022
#3864 introduced a regression by turning on `requireAllFields` globally for JSON parsing. Certain endpoints such as `RestSyncInfo` have optional fields that do not parse correctly without additional changes. This is reverted for now to restore previous behaviour and unblock CI testing.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other changes:
The Keymanager error responses differ from the Beacon API responses.
'keymanagerApiError' replaces the former usages of 'jsonError'.
Return status code 401 and 403 for authorization errors in accordance
to the spec.
Eliminate inconsistencies in the REST JSON parsing. Some of the code
paths allowed missing fields.
Added logging of serialization failure details at DEBUG level.