Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use higher of available engine and builder API bids #4795

Merged
merged 2 commits into from
Apr 11, 2023
Merged

use higher of available engine and builder API bids #4795

merged 2 commits into from
Apr 11, 2023

Conversation

tersec
Copy link
Contributor

@tersec tersec commented Apr 7, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Apr 7, 2023

Unit Test Results

         9 files  ±0    1 074 suites  ±0   31m 46s ⏱️ +8s
  3 675 tests ±0    3 396 ✔️ ±0  279 💤 ±0  0 ±0 
15 668 runs  ±0  15 363 ✔️ ±0  305 💤 ±0  0 ±0 

Results for commit 8510d42. ± Comparison against base commit ed148ab.

♻️ This comment has been updated with latest results.

@zah zah merged commit 0fbf911 into unstable Apr 11, 2023
@zah zah deleted the AXH branch April 11, 2023 15:19
@zah
Copy link
Contributor

zah commented Apr 11, 2023

IIRC, Lighthouse has a special configuration parameter allowing the user to specify preference for local blocks by requiring the blinded block value to exceed the local block value by a specific amount before it's being selected. Something like this can be implemented in a follow-up PR.

@tersec
Copy link
Contributor Author

tersec commented Apr 11, 2023

IIRC, Lighthouse has a special configuration parameter allowing the user to specify preference for local blocks by requiring the blinded block value to exceed the local block value by a specific amount before it's being selected. Something like this can be implemented in a follow-up PR.

Yes, we have an issue #4084 on that and I deliberately kept that out of this PR, to avoid bikeshedding delay/risk. It's a good idea, and now trivial to implement: if using a builder API relay would only net negligible increased profit, but might fail and lose the entire block/payload, when one already has a perfectly good engine API block/payload, then, it's not a good idea to use the builder block and risk proposal failure.

@tersec tersec mentioned this pull request Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants